Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solenoid: apply radiation after multipolar kick #505

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

szymonlopaciuk
Copy link
Collaborator

@szymonlopaciuk szymonlopaciuk commented Jun 12, 2024

Description

Apply the radiation in a solenoid that might contain multipolar kicks at the end of the "sandwich".

Needs xsuite/xobjects#135.

Checklist

Mandatory:

  • I have added tests to cover my changes
  • All the tests are passing, including my new ones
  • I described my changes in this PR description

Optional:

  • The code I wrote follows good style practices (see PEP 8 and PEP 20).
  • I have updated the docs in relation to my changes, if applicable
  • I have tested also GPU contexts

@@ -39,13 +39,57 @@ void Solenoid_track_local_particle(SolenoidData el, LocalParticle* part0) {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe swap these loops

@szymonlopaciuk szymonlopaciuk force-pushed the fix-solenoid-radiation branch 3 times, most recently from 7632f48 to f5ba5af Compare June 13, 2024 12:09
@szymonlopaciuk szymonlopaciuk changed the title Thick slice solenoid: apply radiation after multipolar kick Solenoid: apply radiation after multipolar kick Jun 13, 2024
@szymonlopaciuk szymonlopaciuk marked this pull request as ready for review June 13, 2024 12:53
@szymonlopaciuk szymonlopaciuk merged commit a1114f1 into xsuite:main Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants